Bugs in Multicharts Indicator SQ_KeltnerChannel

During replication of one strategy that uses SQ_KeltnerChannel indicator, I have found several bugs in this indicator.
https://www.investopedia.com/terms/k/keltnerchannel.asp

First bug is that TypicalPrice is used statically in this indicator.
Based on online docs Close should be used here.
This variable can be used dynamically: Close, Open, Low, TypicalPrice, etc...

Second bug is that Average (SMA) is used.
Based on online docs EMA should be used.
This variable can be used dynamically: SMA, EMA, WMA, etc...

Third bug is that in the offset Range is used instead of TrueRange.
Not sure about this. Might be actually not a bug.

After all fixes I think KeltnerChannelDown, KeltnerChannelMiddle and KeltnerChannelUp should be unified too.

Attachments
No attachments
  • Votes +1
  • Project StrategyQuant X
  • Type Bug
  • Status Refused
  • Priority Normal

History

KP
#1

CooleRnax

07.09.2019 20:52

Task created

KP
#2

CooleRnax

07.09.2019 21:10

Description changed:

During replication of one strategy that uses SQ_KeltnerChannel indicator, I have found several bugs in this indicator.
https://www.investopedia.com/terms/k/keltnerchannel.asp

First bug is that TypicalPrice is used statically in this indicator.
Based on online docs Close should be used here.
This variable can be used dynamically: Close, Open, Low, TypicalPrice, etc...

Second bug is that Average (SMA) is used here?
Based on online docs EMA should be used here.
This variable can be used dynamically: SMA, EMA, WMA, etc...

Third bug is that in the offset Range is used instead of TrueRange.

Not sure about this.

After all fixes I think KeltnerChannelDown, KeltnerChannelMiddle and KeltnerChannelUp should be unified too.

KP
#3

CooleRnax

08.09.2019 22:22

Description changed:

During replication of one strategy that uses SQ_KeltnerChannel indicator, I have found several bugs in this indicator.
https://www.investopedia.com/terms/k/keltnerchannel.asp

First bug is that TypicalPrice is used statically in this indicator.
Based on online docs Close should be used here.
This variable can be used dynamically: Close, Open, Low, TypicalPrice, etc...

Second bug is that Average (SMA) is used here?
Based on online docs EMA should be used here.
This variable can be used dynamically: SMA, EMA, WMA, etc...

Third bug is that in the offset Range is used instead of TrueRange.
Not sure about this. Might be actually not a bug.


After all fixes I think KeltnerChannelDown, KeltnerChannelMiddle and KeltnerChannelUp should be unified too.

KP
#4

CooleRnax

08.09.2019 22:26

Description changed:

During replication of one strategy that uses SQ_KeltnerChannel indicator, I have found several bugs in this indicator.
https://www.investopedia.com/terms/k/keltnerchannel.asp

First bug is that TypicalPrice is used statically in this indicator.
Based on online docs Close should be used here.
This variable can be used dynamically: Close, Open, Low, TypicalPrice, etc...

Second bug is that Average (SMA) is used.
Based on online docs EMA should be used.
This variable can be used dynamically: SMA, EMA, WMA, etc...

Third bug is that in the offset Range is used instead of TrueRange.
Not sure about this. Might be actually not a bug.

After all fixes I think KeltnerChannelDown, KeltnerChannelMiddle and KeltnerChannelUp should be unified too.

KP
#5

CooleRnax

11.09.2019 15:03
Voted for this task.
MF
#6

Mark Fric

23.09.2019 14:57

Status changed from New to Refused

I don't think this is a bug. Our implementation of some indicators is based on their MetaTrader4 implementation, which might not always be the standard one. That is why we implement many of indicators by ourselves also in EasyLanguae.


We can make a "standard" implementation of KeltnerChannel as a separate building block, but it is a feature request, not a bug.

And it doesn't have that big priority right now.


KP
#7

CooleRnax

23.09.2019 15:01
Agree can be closed

Votes: +1

Drop files to upload

or

choose files

Max size: 5MB

Not allowed: exe, msi, application, reg, php, js, htaccess, htpasswd, gitignore

...
Wait please