[114] "sF" parameter of "QQE" indicator should use global period min and max values

The "sF" parameter of "QQE" actually is a moving average (if you look at the source code) and hence this should use the global period min and max values, but this can´t be selected right now. Please change that, thanks.
Attachments
3.jpg
(743.17 KiB)
  • Votes 0
  • Project StrategyQuant X
  • Type Bug
  • Status Fixed
  • Priority Normal

History

g
#1

geektrader

20.11.2018 06:34

Task created

h
#2

hankeys

20.11.2018 08:16

i agree that SF need to be set by global setting, but wf is not wf, but correctly its WP


SF (smoothing factor) - WP (wilders periods)


also the WP could be set as global, because 3 decimal step doesnt do any diff


levels 0-100, step 5

g
#3

geektrader

20.11.2018 08:59
Yea, they´ve got that wrong for the naming too indeed ;-)


As for the decimal steps, those do make a difference, just try in MT4 and you´ll see that even changing those by 0.01 (for example from 4.35 to 4.36) makes the indicator lines give different crossings. So please keep those like that, Mark - thanks :)

TB
#4

Tomas Brynda

20.11.2018 10:47

Status changed from New to Fixed

WF is not intended to be a Wilders Period. Wilders Period is calculated automatically as RSIPeriod * 2 - 1. WF is a multiplier that is used in calculations
g
#5

geektrader

20.11.2018 16:25
Well, the parameter WF within SQ (it´s called SF in the actual SqQQE.mq4 that you supply in the custom indicators folder) that I´ve reported is clearly a moving average on an array of the RSI, smoothing it out, and so it should be using the global min / max values for Period:



        Rsi[i] = iRSI(NULL, 0, RSI_Period, PRICE_CLOSE, i);     for (i = counted; i >= 0; i--)     {         RsiMa[i] = iMAOnArray(Rsi, 0, SF, 0, MODE_EMA, i);



.................


Please change, thank you :-)

TB
#6

Tomas Brynda

20.11.2018 17:13
Yes, I agree with you - SF is a period for moving average, it is already updated to use the global period. 


In MQL code, the parameter WP should be named WF to make it clear. It's just a matter of variable name, the computation is the same as in SQ. 

I didn't noticed that at first, because I was looking into a snippet. It will be fixed too. 


Thank you 

g
#7

geektrader

20.11.2018 19:29
Superb :-) Thank you :-)

Votes: 0

Drop files to upload

or

choose files

Max size: 5MB

Not allowed: exe, msi, application, reg, php, js, htaccess, htpasswd, gitignore

...
Wait please