[Build 126] Order comment is not persisted in order history

Hello,

Problem statement:

If a strategy (sample based on Examples attached) uses comments to identify order, the comment itself is not saved in order history (see Capture1).

Expected result:

Order comments are saved in order history. And ideally left align the value in result viewer.

Proposed fix:

Analyzing code and backporting in SQX122 problem seems related to class com.strategyquant.tradinglib.Order, method public void setFromLiveOrder(ILiveOrder,..)
Proposed fix is adding a single line to the method
  ...
      this.Comment = liveOrder.getComment();
  ...

After patching the method a correct comments are reported in order history (see Capture2).

Did not analyze dependencies (like orders with deleted comment). Hope it helps.

Tnx,

BR Enyx
Attachments
Capture2.png
(66.87 KiB)
CommentTestStrategy.sqx
(2.50 KiB)
Capture1.png
(58.26 KiB)
  • Votes 0
  • Project StrategyQuant X
  • Type Bug
  • Status Fixed
  • Priority High

History

DB
#1

Enyx

18.04.2020 19:09

Task created

DB
#2

Enyx

18.04.2020 19:22

Attachment Capture3.png added

Attachment Capture4.png added

Addendum. Not sure if a new bug..


In SQX122 comment is a variable and strategy created with that assumption (Capture3)

In SQX126 comment is treated as text and replaced by variable guid.. (Capture 4)



MF
#3

Mark Fric

23.04.2020 10:58

Status changed from In progress to Fixed


Votes: 0

Drop files to upload

or

choose files

Max size: 5MB

Not allowed: exe, msi, application, reg, php, js, htaccess, htpasswd, gitignore

...
Wait please