Typos in Multiple Building Blocks

Should not be too much of a big deal but I believe this is a typo.



Many of the Bollinger Band Indicator signals say "Bar opens above/below x  after opened above/below x"  But this would not be correct because obviously a bar cannot open twice within the same bar. I believe these should say "Bar CLOSES above/below, after opened above/below x" 


Also worth checking out if the code for this building block is already comparing the close to the open or if it is abiding by the typos and looking for the open of the bar to occur twice which is wrong.

Attachments
Screen Shot 2020-07-10 at 54102 PM.png
(363.06 KiB)
  • Votes 0
  • Project StrategyQuant X
  • Type Bug
  • Status Refused
  • Priority Normal

History

KL
#1

kainc301

10.07.2020 23:48

Task created

KL
#2

kainc301

10.07.2020 23:56

Attachment Screen Shot 2020-07-10 at 55514 PM.png added

Screen Shot 2020-07-10 at 55514 PM.png
(117.95 KiB)
Im finding more of these throughout the building blocks. Going to see if I can spot them all. Let me know if these look like typos for the reasons stated above. Same logic applies.
KL
#3

kainc301

11.07.2020 00:04

Attachment Screen Shot 2020-07-10 at 60025 PM.png added

Screen Shot 2020-07-10 at 60025 PM.png
(295.37 KiB)
These are everywhere so if they are purposeful, is it referring to the subsequent bar? Because the wording makes it seem like it is referring to the same bar that has closed at a significant location compared to where it opened.
KL
#4

kainc301

11.07.2020 00:05

Subject changed from Building block typo to Typos in Multiple Building Blocks

MF
#5

Mark Fric

13.07.2020 14:17

Status changed from New to Refused

the naming is correct, the condition checks for Open of two subsequent bars.


For example: Bar opens above Lower band after opened below evaluates as:

double value1 = Strategy.Indicators.BollingerBands(Chart.getSeries(ComputedFrom), Period, Deviation).Lower.getRounded(1);

return (Chart.Open(1) < value1) && (Chart.Open(0) > value1);



So it checks if current bar opened above and previous bar opened below.



There are another conditiond to check for Open and Close.

TT
#6

Tamas

13.07.2020 14:20

Status changed from Refused to New

KL
#7

kainc301

13.07.2020 14:45
Oh okay, its the subsequent bar. That was unclear from the naming convention but thank you for clearing that up
TT
#8

Tamas

13.07.2020 15:27

Status changed from New to Refused


Votes: 0

Drop files to upload

or

choose files

Max size: 5MB

Not allowed: exe, msi, application, reg, php, js, htaccess, htpasswd, gitignore

...
Wait please