[129RC1] Missing end user reporting

Some of program code has incomplete error/handling and/or end user reporting. Seen in many areas  including some important ones.

Many errors are not reported to end user creating illusion all worked well.

Illustrative example: Missing end user reporting:

Backend:

onSetRemoteAccess {
....
jsonObject.put("success", )"Settings saved.");
return jsonObject.toString();
}
catch (Exception ex) {
return HttpJSONServlet.apiErrorJSON("Error while saving remote access settings", ex);
}
GUI code:

$scope.onSaveRemoteAccessSettings = function(){
BackendService.sendRequest('/main/setremoteaccess', $scope.remoteAccess, function(){
$rootScope.showSuccess(L.tsq("Remote Access settings saved.")); <<-- Returned error by backend is ignored. Only reporting success

hidePopup('#remoteAccessDialog');
});
}
Tx. Enyx
Attachments
No attachments
  • Votes 0
  • Project StrategyQuant X
  • Type Bug
  • Status Refused
  • Priority Normal

History

DB
#1

Enyx

03.08.2020 09:57

Task created

TB
#2

Tomas Brynda

03.08.2020 11:22

Status changed from New to Refused

If you looked deeper into the code, you would see that BackendService.sendRequest handles errors internally and when an error occurs on backend, it shows an error message and doesn't call callback function.
?
#3

anonymous

03.08.2020 12:42

Tomas, absolutely correct, checked it,  accept my apologies.


I got confused buy the original error which seems ignored within backed and not being reported back to GUI itself. There is a separate bug on this one.


Enyx




Votes: 0

Drop files to upload

or

choose files

Max size: 5MB

Not allowed: exe, msi, application, reg, php, js, htaccess, htpasswd, gitignore

...
Wait please